Embedded Linux

[norman_wong]

Some files in U-boot still include xparameters.h directly rather than indirectly using config.h. As a result, some files include xparameters.h rather than xparameters_zynq.h. The Xilinx server looks to be unresponsive for me. I can't check if this has already been addressed. In version 14.1-build3-trd, the files of interest are board.c, mmc.c and pele_qspi.c.

[linnj]

We're doing a lot of u-boot cleanup so I'll make sure that we get this into that also if it's not already.

I'm not seeing an issue with the git server now.  If you still see issues please say so and I'll have some more looking at it.

Thanks

John

[norman_wong]

Looks like a lot of reorganization has occcured since 14.1-build3-trd. At the time of this writing, the head is
h=9c040f8d85b33868d9b15d59ae12e981a737d433

These files have been moved and no longer include xparameters.h directly
  board/xilinx/zynq_common/board.c

These files have been moved/renamed and does still include xparameters.h directly
  drivers/mmc/zynq_mmc.c
  drivers/spi/zynq_qspi_wrap.c

The xparameters files appear to have been merged, moved and renamed into one? Pele has been dropped.

  arch/arm/include/asm/arch-zynq/xparameters.h
  arch/arm/include/asm/arch-zynq/xparameters_ps.h (Not pss)

I am wondering what is the design intent of the xparameters files. The xparameters_ps.h file seems to be Zynq intrinsic defines. They cannot change between boards. The xparameters.h file would seem to me more of board definition file.I think that the defines in xparameters.h might fit better in the board config file.

The effort to change the 7C702 code base for a custom board has not been trivial. Upgrading to a new version would be quite a chore. Upgrading at all would have to carefully considered. All the changes since 14.1-build3-trd look to simplifying the task. Hopefully eventually a custom board can be handled in one file separate from ZC702 code.

[linnj · Accepted solution]

Yes there is a lot of change in 14.2 release coming up. The intent of xparameters.h is to communicate information from the SDK tools about the PS configuration to u-boot, similar to the device tree for Linux which can be generated out of the SDK. Ideally, one of these days, u-boot will then take a device tree for confifguring itself also rather than the xparameters.

yes we're trying to get some stuff cleaned up to make it easier. We know it was a bit of a mess and we're working on it with the goal of eventually getting back to pushing upstream.

Thanks.

[norman_wong]

Sounds good. Look foward to 14.2 release. Hopefully 14.2 of the SDK tools will also clean up the many many many redefinition warnings between xparameters.h and xparameters_ps.h. If you can whisper in someones ear that the autogenerated FSBL code is totally detached from the SDK. It still uses xparameters_pss.h (as in pss vs ps). But at least it's xparameters.h and xparameters_pss.h are compatible with each other.

[balister]

Will the u-boot clean up also update the underlying u-boot? It looks like the zynq u-boot is based of a 2009 u-boot. There have been some miportnat changes in some of the modules used in zynq. Also, some of the commands are different and it is pain remembering the old form :)

From previous projects, it is easy to get stuck on old u-boots, and the pain increases the longer you wait to get your work upstream. Once everything is upstream, things get real easy :)