UPGRADE YOUR BROWSER

We have detected your current browser version is not the latest one. Xilinx.com uses the latest web technologies to bring you the best online experience possible. Please upgrade to a Xilinx.com supported browser:Chrome, Firefox, Internet Explorer 11, Safari. Thank you!

cancel
Showing results for 
Search instead for 
Did you mean: 
Highlighted
Visitor athanasis
Visitor
3,518 Views
Registered: ‎11-07-2012

XGPIOPS driver in linux OSL 14.3

In my opinion xgpiops_request in the gpio_xilinxps.c  is implemented incorrectly as pm_runtime_get might return 1 and in case of a gpio_request that will be considered as ab error and any gpio request will fail, while the purpose of pm_runtime_get is to wake the gpio device . Below I am showing the change I did. I believe the driver should also be changed in the main repository

 

Therefore I modified it to

 

static int xgpiops_request(struct gpio_chip *chip, unsigned offset)
{
	int ret;
	ret = pm_runtime_get(chip->dev);
	if ( ret < 0 )
		return ret;
	else{
		return 0;
	}
}

 

 

0 Kudos
1 Reply
Xilinx Employee
Xilinx Employee
3,494 Views
Registered: ‎09-10-2008

Re: XGPIOPS driver in linux OSL 14.3

Thanks, we'll incorporate as we got a patch from Lars-Peter.
0 Kudos