cancel
Showing results for 
Show  only  | Search instead for 
Did you mean: 
Highlighted
Observer
Observer
1,259 Views
Registered: ‎07-23-2013

AR65444 Driver Version: 0.45 Small Issue

Jump to solution

Hi,

 

I appreciate this driver. I was looking through the code and there seems to be a small issue.

 

xdma-core.c Line 3927

 

This block of code is repeated twice:

 

        /* fetch device specific data stored earlier during open */
        lro_char = (struct xdma_char *)file->private_data;
        BUG_ON(!lro_char);
        BUG_ON(lro_char->magic != MAGIC_CHAR);

        lro = lro_char->lro;
        BUG_ON(!lro);
        BUG_ON(lro->magic != MAGIC_DEVICE);

        engine = lro_char->engine;

Dave

 

1 Solution

Accepted Solutions
Highlighted
Moderator
Moderator
1,680 Views
Registered: ‎02-16-2010
Thanks for reporting this. We will review and fix the code as required.
------------------------------------------------------------------------------
Don't forget to reply, give kudo and accept as solution
------------------------------------------------------------------------------

View solution in original post

0 Kudos
4 Replies
Highlighted
Moderator
Moderator
1,681 Views
Registered: ‎02-16-2010
Thanks for reporting this. We will review and fix the code as required.
------------------------------------------------------------------------------
Don't forget to reply, give kudo and accept as solution
------------------------------------------------------------------------------

View solution in original post

0 Kudos
Highlighted
Adventurer
Adventurer
1,048 Views
Registered: ‎08-10-2017

@venkata @cospandesign

 

Is it safe to comment out the repeated version of the block ?

0 Kudos
Highlighted
Adventurer
Adventurer
1,041 Views
Registered: ‎08-10-2017

@venkata

 

The reason I asked is that, I am unable to use the new version of the driver Xilinx_Answer_65444_Linux_Files_rel20180420.zip because I noticed in dmesg log that xdma_isr() is continuously being executed even though FPGA logic is not generating that interrupt. I pointed out this error in https://forums.xilinx.com/t5/PCI-Express/no-C2H-channels-enabled-AR65444/m-p/855547#M10854

 

 

0 Kudos
Observer
Observer
975 Views
Registered: ‎07-23-2013

Hi,

 

Commenting out that portion of the code will have no effect on your issue. That part of the code just assigned three values to thee locations and then assigned those three values again.

 

Structurally it didn't change anything.